Sockeye 2 heafield quantize pr2 #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhieber
approved these changes
May 22, 2020
sockeye/quantize.py
Outdated
|
|
||
| log_sockeye_version(logger) | ||
|
|
||
| params_best = os.path.join(args.model, C.PARAMS_BEST_NAME) |
There was a problem hiding this comment.
Code below could also be moved into another function with only one string argument to avoid calling main functions in a library use case.
There was a problem hiding this comment.
That's a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a housekeeping PR that follows #771 including:
sockeye.quantizeCLI for annotating a trained model with int8 scaling factors for fast loading/quantizationWhen this PR is merged into
sockeye_2_heafield_quantize, that branch can be merged immediately intosockeye_2.Pull Request Checklist
until you can check this box.
pytest)pytest test/system)./style-check.sh)sockeye/__init__.py. Major version bump if this is a backwards incompatible change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.